Enhanced A1-Test-App and A2-Test-App to automatically generate best download wait times#74
Open
MonteCreasor wants to merge 3 commits intodouglascraigschmidt:masterfrom
MonteCreasor:master
Open
Enhanced A1-Test-App and A2-Test-App to automatically generate best download wait times#74MonteCreasor wants to merge 3 commits intodouglascraigschmidt:masterfrom MonteCreasor:master
MonteCreasor wants to merge 3 commits intodouglascraigschmidt:masterfrom
MonteCreasor:master
Conversation
…it time for downloading multiple images depending on connection speeds and image sizes. This makes it unnecessary for students to ever need to adjust the wait time parameters for their specific hardware environment.
…it time for downloading multiple images depending on connection speeds and image sizes. This makes it unnecessary for students to ever need to adjust the wait time parameters for their specific hardware environment.
…it time for downloading multiple images depending on connection speeds and image sizes. This makes it unnecessary for students to ever need to adjust the wait time parameters for their specific hardware environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to automatically adjust the waitForActivity() call for the DisplayImagesActivity. The calculation is based on the largest image in the image test set and takes into consideration the connection speed on each machine that it is run on. This solution does not require the students to ever have to make changes to waitTime constants. It has been tested on the fastest possible connection as well as the slowest possible connection (which takes roughly 10 minutes to download 6 images since I used GSM and GPRS, and I also tested it with EDGE speed).
I think you will get very few complaints with this design in the future. It is worth noting that Test4_SingleValidUrl is used to set the best wait time for the specific uses and their connection speed. The Images have also been changed: I remove 2 of the larger images that exceed 1000KB and replaced them with ones that are around 150KB (and those are to two largest now).