Open
Conversation
dpastoor
requested changes
May 4, 2017
Owner
dpastoor
left a comment
dpastoor
left a comment
There was a problem hiding this comment.
Overall I really like the idea. The couple things that will need to be changed:
- add DiagrammeR to suggests
- add a
head()of the dataset
Perhaps also some very light exploratory visualization regarding the time-course and or demographics (at least for sd_iv
| --- | ||
|
|
||
| ```{r echo=FALSE} | ||
| library(DiagrammeR) |
Owner
There was a problem hiding this comment.
we'll need to add DiagrammeR to Suggests so the vignette can be knit. Really like the idea
| date: "`r Sys.Date()`" | ||
| output: rmarkdown::html_vignette | ||
| vignette: > | ||
| %\VignetteIndexEntry{Single Dose IV - PKPD} |
Owner
There was a problem hiding this comment.
Try to keep the vignette name as simple as possible since they'll have to type it exactly in vignette(...) maybe tie it directly to the dataset (I presume this is for sd_iv_rich_pkpd?
Owner
|
pushed some documentation tweaks so will build vignettes into documentation now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey. can you check out the format of the vignettes for the datasets in here. Just wondering if this sort of information is useful for the datasets package?