Hostname not correctly added to ssl certificate #40
Open
rickiewars wants to merge 2 commits intodperson:masterfrom
Open
Hostname not correctly added to ssl certificate #40rickiewars wants to merge 2 commits intodperson:masterfrom
rickiewars wants to merge 2 commits intodperson:masterfrom
Conversation
Organization was not set properly in SSL Certificate. This change should fix it.
I needed to place a space between thesecond and last backslash on line 19 to be able to compile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The organization name is not set properly in the creation of the SSL certificate. This was due to a typo (forgot one '$' sign). This should fix it.
Note: I'm not sure of the change in the Dockerfile. I needed to change what I did to be able to create the docker image.