First attempt to display further face data#11
Open
BenChampion wants to merge 1 commit intodpethes:masterfrom
Open
First attempt to display further face data#11BenChampion wants to merge 1 commit intodpethes:masterfrom
BenChampion wants to merge 1 commit intodpethes:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at the HOB files (see #10) I noticed that each meshdef0 ("object part") could be associated with multiple meshdef1 structs ("face groups"/"object subparts" - I don't know what the best terminology is). This is a rough attempt to restructure
hob_parserandmodel_viewerto account for this and recover more face/vertex data. It works for many models, butdata2/koelsch_HOBdoesn't look quite right anddata/level/lv_4/opkg_HOBgives amesh loading failed :(message (this is strange since my python parser doesn't have any issues, but I may not be looking closely enough e.g. at the HMT yet).Anyway I thought I'd put this here as a "work in progress". Maybe a better data structure would be for each THobObjectPart to contain an array/list of THobFaceGroup.