Fix "Invalid format string" in Windows#55
Open
raulsiles wants to merge 2 commits intodpnishant:masterfrom
Open
Fix "Invalid format string" in Windows#55raulsiles wants to merge 2 commits intodpnishant:masterfrom
raulsiles wants to merge 2 commits intodpnishant:masterfrom
Conversation
ValueError: Invalid format string %l is not standard: %l - Hour of the day, 12-hour clock, blank-padded ( 1..12) The Windows implementations doesn't support it: https://msdn.microsoft.com/en-us/library/fe06s4ak.aspx https://docs.python.org/3/library/time.html Use %I instead: %I - Hour of the day, 12-hour clock, zero-padded (01..12)
ValueError: Invalid format string %l is not standard: %l - Hour of the day, 12-hour clock, blank-padded ( 1..12) The Windows implementations doesn't support it: https://msdn.microsoft.com/en-us/library/fe06s4ak.aspx https://docs.python.org/3/library/time.html Use %I instead: %I - Hour of the day, 12-hour clock, zero-padded (01..12)
dpnishant
reviewed
Oct 4, 2017
Owner
dpnishant
left a comment
There was a problem hiding this comment.
Is this is a Windows only issue? Because the current format string works good on Linux and macOS. It would be better if you can first detect OS and the use the correct format.
Contributor
Author
|
I assume this is a Windows only issue, as well as the other Windows-related pull requests I submitted last week. However, I have not tested them specifically in all supported OSes. For this one, I suggest to use the same code for all OSes (Windows, Linux, macOS...), that is, a date representation that is standard for all them: uppercase i vs. lowercase l. For the others, if the additional color library and reference does not break the behavior of Linux and macOS, I also suggest to use the same code for them all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueError: Invalid format string
%l is not standard: %l - Hour of the day, 12-hour clock, blank-padded ( 1..12)
The Windows implementations doesn't support it:
https://msdn.microsoft.com/en-us/library/fe06s4ak.aspx
https://docs.python.org/3/library/time.html
Use %I instead: %I - Hour of the day, 12-hour clock, zero-padded (01..12)