Open
Conversation
Added trace support to database\__init__.py templates\monitor.html and scripts/* Added common script trace function scripts\!Common\trace.js
Owner
|
Hi @ChD1 , Thank you so much for your contribution. I really appreciate you interest in improving the project. But I would like you to split your larger PRs into multiple smaller and specific PR. This would help us to test and then merge. Regarding the python version upgrade related code, I would prefer to have it in a separate branch, otherwise, people already using the tool with Python 2.x environment will have go through dependency upgrades and it might break things on their side. Regarding the tracing support, we can add it via a command-line argument so it can be enabled/disabled at will. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python 3.6 converted.
Added trace support
Added new script