Skip to content

Conversation

@b1ackviking
Copy link

Tmux 3.6 does not accept comma-separated modifiers in #[] blocks. Splitting them into separate #[] blocks works.

Closes #366

Tmux 3.6 does not accept comma-separated modifiers in `#[]` blocks.
Splitting them into separate `#[]` blocks works.

Closes dracula#366
@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

📝 Walkthrough

Walkthrough

This PR fixes tmux 3.6 compatibility by refactoring the dracula.sh status line configuration to separate formatting attributes into discrete tokens. The change addresses a breaking tmux 3.6 update that no longer supports comma-separated attribute declarations within formatting blocks.

Changes

Cohort / File(s) Summary
TMUX Status Line Format Refactoring
scripts/dracula.sh
Reworks all status-left and status-right formatting strings to replace composite patterns like #[bg=...,fg=...,bold] with separate tokenized segments (#[bg=...]#[fg=...]#[bold]). Updates window status formatting to split fg/bg settings and insert explicit styling tokens (nobold, nounderscore, noitalics). Maintains visual behavior while achieving tmux 3.6 compatibility.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Primary focus: Verify consistent application of the token-separation pattern across all status line declarations
  • Ensure no formatting declarations with commas remain in the file
  • Confirm visual output matches the expected powerline appearance after changes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing status bar rendering in tmux 3.6 by addressing comma-separated modifiers.
Description check ✅ Passed The description clearly explains the issue and solution: tmux 3.6 does not accept comma-separated modifiers in #[] blocks, and splitting them fixes rendering.
Linked Issues check ✅ Passed The pull request changes directly address issue #366 by replacing comma-separated modifiers in #[] blocks with separate blocks, restoring status bar rendering compatibility with tmux 3.6.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing the tmux 3.6 status bar rendering issue; only scripts/dracula.sh is modified with targeted formatting adjustments.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 91a1e09 and 3e20ede.

📒 Files selected for processing (1)
  • scripts/dracula.sh (3 hunks)
🔇 Additional comments (1)
scripts/dracula.sh (1)

175-175: ✓ Correctly separates comma-separated tmux format modifiers for 3.6 compatibility.

The refactoring properly converts composite format patterns (e.g., #[bg=...,fg=...,bold]) into discrete tokens (e.g., #[bg=...]#[fg=...]#[bold]). The syntax is correct across all changed lines:

  • Status-left configurations (lines 175, 177, 181)
  • Right-edge and status-right plugin rendering (lines 364, 375, 377, 382, 384)
  • Window-status-current formatting (lines 392, 394)

The changes appear complete—unchecked format strings on lines 140–141 and 397 already use the new syntax or don't require changes.

Please confirm testing on tmux 3.6 to verify that the status bar rendering matches the expected output shown in issue #366. If available, test on both transparent and non-transparent powerline modes, with and without edge icons, to ensure all code paths render correctly.

Also applies to: 177-177, 181-181, 364-364, 375-375, 377-377, 382-382, 384-384, 392-392, 394-394


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Bug: powerline status bar rendering broken after tmux 3.6 update

1 participant