Skip to content

Redact sensitive information#3

Open
faijdherbe wants to merge 2 commits intodragino:mainfrom
faijdherbe:redact-sensitive-information
Open

Redact sensitive information#3
faijdherbe wants to merge 2 commits intodragino:mainfrom
faijdherbe:redact-sensitive-information

Conversation

@faijdherbe
Copy link

It is generally not a good practice to push IP's and TOKENS to public (git) repositories, as it might lead to security issues.

This MR removes this information from some (test?) scripts at project root.

⚠️ It's probably best to invalidate all relevant tokens in the relevant service as well.

Jeroen Faijdherbe added 2 commits November 10, 2023 12:04
These tokens should also be invalidated upstream, as the removal in
this commit does not remove them from the git history.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant