Skip to content

Conversation

@doronz88
Copy link

No description provided.

@AdamWill
Copy link

LGTM. With this, tuya-convert works on Python 3.13. Without it, it does not.

@doronz88
Copy link
Author

I don't think this package is going to be maintained and also python 3.13 has this feature builtin so it's no longer necessary.

If anyone is interested, I forked this repo into my own sslpsk-pmd3 quite a long time ago

@AdamWill
Copy link

AdamWill commented Feb 22, 2025

It's not strictly necessary, but tuya-convert is written to use this, and with sslpsk patched with this PR, tuya-convert works as-is. To use the new Python built-in PSK support, tuya-convert would need a patch.

Also, ssl.wrap_socket was dropped in 3.12, but only 3.13 added the built-in PSK stuff, so anyone who's on exactly Python 3.12 really needs this.

I'll send a PR for tuya-convert to use your fork for now, I guess. Not sure if I want to figure out how to rejig tuya-convert to work with the built-in PSK stuff. Thanks.

AdamWill added a commit to AdamWill/tuya-convert that referenced this pull request Feb 23, 2025
This is the stuff I found I needed to make this script work on
Fedora. We also install the branch of sslpsk that backs this PR:
drbild/sslpsk#28
because current upstream sslpsk does not work on Python 3.12+,
and so does not work on current stable Fedora.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
AdamWill added a commit to AdamWill/tuya-convert that referenced this pull request Jul 24, 2025
This is the stuff I found I needed to make this script work on
Fedora. We also install the branch of sslpsk that backs this PR:
drbild/sslpsk#28
because current upstream sslpsk does not work on Python 3.12+,
and so does not work on current stable Fedora.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
@kuba2k2
Copy link

kuba2k2 commented Sep 2, 2025

There is an updated version called sslpsk3 v2.0.0, which I just released with support for SSLContext and wrap_socket. Both methods work on Python 3.7-3.13+, additionally it transparently uses the built-in methods that are available on 3.13 and newer. The new library is a drop-in replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants