Conversation
![orca-security-in[bot]](https://avatars.githubusercontent.com/in/276246?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
| "password": "dg", | ||
| "batch_size": 1, | ||
| "throttle": "10ms", | ||
| "timeout": "30s" |
There was a problem hiding this comment.
are we supporting timeouts?? is it there for mysql as well?? is this supported in code??
There was a problem hiding this comment.
its connection timeout, supported in code as well, not present for mysql
There was a problem hiding this comment.
add a task for that to keep uniformity in features where ever possible
| - Ensure user has INSERT privileges on target tables | ||
| - Use appropriate `batch_size` and `throttle` to control load rate | ||
| - When `clear_data` is enabled, the target table is truncated using `TRUNCATE TABLE ... RESTART IDENTITY CASCADE`, which resets sequences and cascades to dependent tables | ||
| - Connection uses `sslmode=disable` by default |
There was a problem hiding this comment.
also these features were not enabled in mysql or atleast not mentioned in docs....if features are there but not mentioned in doc, create a task to add in mqsql.mdx as well
There was a problem hiding this comment.
we are using sslmode=disable only and not supporting sslmode enable
There was a problem hiding this comment.
i mean clear_data is there in mysql as well right?? but not mentioned in doc...so for uniformity we can add this as well in mysql.mdx file or whatever to make feature info consistent...
3 participants
Description
Please provide a brief summary of your changes. Explain what you have done, what you are doing, and why you have chosen to do it this way.
Issue(s) Solved
Please list the issue(s) that are addressed by this PR.