Fix CI: update nodelint.yml actions and regenerate electron lock file#925
Merged
Fix CI: update nodelint.yml actions and regenerate electron lock file#925
Conversation
- Upgrade checkout@v3 and setup-node@v3 to v4 in nodelint.yml - Regenerate electron/package-lock.json on Linux to add missing optional dependency entries (encoding@0.1.13, iconv-lite@0.6.3) required by minipass-fetch but omitted when generated on macOS Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
github
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutandactions/setup-nodefrom v3 → v4 innodelint.yml(v3 is unmaintained)electron/package-lock.jsonon Linux (via Docker) to add missing optional dependency entries (encoding@0.1.13,iconv-lite@0.6.3) thatminipass-fetchrequires but macOS npm omits from the lock filenpm cion Linux CI validates that all deps listed in any lock file entry have their own resolved entries — including optional ones — which the macOS-generated lock file was missingTest plan
run-node-lintandrun-node-lint-electronCI jobs pass on this PR🤖 Generated with Claude Code