Replace AtomicInteger with Integer for SlaveRefCount to fix deserialization and logic bugs#494
Open
tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
Open
Replace AtomicInteger with Integer for SlaveRefCount to fix deserialization and logic bugs#494tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
Conversation
Author
tsautier
force-pushed
the
fix/issue-52-slaverefcount
branch
2 times, most recently
from
a1aa7e5 to
a8e8f90
Compare
tsautier
changed the title
tsautier
force-pushed
the
fix/issue-52-slaverefcount
branch
from
a8e8f90 to
68a7b8a
Compare
…efCount to fix deserialization and logic bugs
tsautier
force-pushed
the
fix/issue-52-slaverefcount
branch
from
68a7b8a to
301b53f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SlaveRefCount variable for VFS inodes has issues with json-io deserialization. The AtomicInteger in
_slaveRefCountsfails to deserialize properly, causing data corruption and incorrect reference tracking.Solution
Fix the SlaveRefCount serialization/deserialization to handle AtomicInteger properly.
Changes Made
Fixes: #52