Prevent ArithmeticException in Session.getReplacerEnvironment#495
Open
tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
Open
Prevent ArithmeticException in Session.getReplacerEnvironment#495tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
Conversation
Author
tsautier
force-pushed
the
fix/issue-345
branch
from
e24fc24 to
409d16b
Compare
…placerEnvironment
tsautier
force-pushed
the
fix/issue-345
branch
from
409d16b to
9eb2ada
Compare
tsautier
changed the title
tsautier
force-pushed
the
fix/issue-345
branch
3 times, most recently
from
4b25ea0 to
9eb2ada
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Login fails with
java.lang.ArithmeticException: / by zerowhen calculating average speed for a user. This occurs inSession.javawhen the user has zero time tracked.Solution
Add a check for zero divisor before calculating average speed.
Changes Made
Session.javato check for zero time before divisionFixes: #345