Gracefully handle FileNotFoundException in slave command execution#503
Open
tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
Open
Gracefully handle FileNotFoundException in slave command execution#503tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
Conversation
Author
tsautier
force-pushed
the
fix/issue-328
branch
from
44f1e1c to
c48930a
Compare
…lave command execution
tsautier
force-pushed
the
fix/issue-328
branch
from
c48930a to
72e452b
Compare
tsautier
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Slave crashes when nuking/deleting/moving/wiping a release while files are actively being transferred. The
FileNotFoundExceptionthrown fromRootCollection.getRootForFile()was not being caught, causing the slave to disconnect.Solution
Add specific handling for
FileNotFoundExceptionin the slave's async command handler to prevent crashes during race conditions.Changes Made
Slave.AsyncCommandHandler.run()to catchFileNotFoundExceptionFixes: #328