Refactor ZipscriptMP3Handler and add JUnit test for invalid MP3s#504
Open
tsautier wants to merge 2 commits intodrftpd-ng:masterfrom
Open
Refactor ZipscriptMP3Handler and add JUnit test for invalid MP3s#504tsautier wants to merge 2 commits intodrftpd-ng:masterfrom
tsautier wants to merge 2 commits intodrftpd-ng:masterfrom
Conversation
Author
8521be3 to
5e0f286
Compare
5e0f286 to
7c26b4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When encountering an invalid MP3 file, the slave would throw an IOException with message "X is not a valid MP3 file", causing errors in the async command handler.
Solution
Catch the specific IOException in
ZipscriptMP3Handler.getMP3File()and return null instead of propagating the exception. This allows graceful handling of invalid MP3 files.Changes Made
ZipscriptMP3Handler.javato catch IOException when parsing MP3 filesFixes: #77