Make IMDB URLs configurable in MediaInfo#506
Open
tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
Open
Make IMDB URLs configurable in MediaInfo#506tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
Conversation
Author
ada874f to
c1559d3
Compare
c1559d3 to
fc08ef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
IMDB URLs (
https://imdb.com,https://imdb.com/find?s=all&q=) were hardcoded inIMDBParser.java. If IMDB changed their domain or URL structure, users couldn't fix it without modifying source code and recompiling.Solution
Move IMDB URLs to the configuration file (
imdb.conf) so users can update them without code changes.Changes Made
1. Added URL Config to imdb.conf.dist
Added new configuration options:
2. Modified IMDBParser to Load URLs from Config
Changed from hardcoded constants to config-loaded values with sensible defaults:
ConfigLoader.loadPluginConfig("imdb.conf")to constructorBenefits
Fixes: #126