WIP: Enable certificate-based authentication for slaves#511
Open
tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
Open
WIP: Enable certificate-based authentication for slaves#511tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
tsautier wants to merge 1 commit intodrftpd-ng:masterfrom
Conversation
Author
tsautier
force-pushed
the
feat/issue-138-cert-auth
branch
from
1e856b8 to
4d329d5
Compare
Implemented support for mTLS client authentication in SlaveManager. Added certificate fingerprint verification in RemoteSlave. Introduced 'slavemanager.ssl.clientauth' and 'fingerprint' configuration properties.
tsautier
force-pushed
the
feat/issue-138-cert-auth
branch
from
4d329d5 to
1d12366
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, Slaves are authenticated solely by their IP address matching a configured hostmask. This is insecure (IP spoofing) and difficult to manage for Slaves with dynamic IP addresses.
Solution
Implement Mutual TLS (mTLS) authentication. The Master can now request a client certificate from the Slave and verify its SHA-256 fingerprint against the Slave's configuration.
Changes Made
slavemanager.ssl.clientauthproperty (none,want,need) to control client certificate requests during the TLS handshake.checkCertificate()method tocheckConnect(). It calculates the peer certificate's fingerprint and compares it to thefingerprintproperty in the slave's config.slavemanager.ssl.clientauth=want(recommended)."fingerprint": "SHA256:..."to enforce validation.Verification
SlaveManagercorrectly configures theSSLServerSocketbased on the property.RemoteSlavecorrectly extracts and hashes the certificate.PassiveConnection,ActiveConnection) are unaffected and do NOT enforce client auth, preserving compatibility.Fixes: #138