Feature/getsetcmd mixin #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified Service to include this class.
Adding necessary functionality to get commands.
…returns with 'values' field without a specifier.
nsoblath
requested changes
Apr 10, 2025
Member
nsoblath
left a comment
nsoblath
left a comment
There was a problem hiding this comment.
Nice job on this. Just a small-ish change requested to simplify the definition of on_get() and on_set().
This was
linked to
issues
Apr 11, 2025
nsoblath
requested changes
Apr 11, 2025
This was
linked to
issues
Apr 11, 2025
…rvice trampoline class.
… from the C++ base class
…iver --> RequestHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Adjusted services and endpoints to be able to return dicts on get requests, and handle bad objects in returns.
Mixin class for services and interfaces to be able to execute gets, sets, and cmds.
Mixin class for services and endpoints to be able to respond to gets, sets, and cmds.
Fixes
Testing
Tests conducted on personal machine, using code in
scripts/pkolbeck_scripts/dripline_testingpytest in dripline-python/tests.
KNOWN ISSUES
A service querying an endpoint that it holds breaks the service somehow via creating new (bad?) channels in the rabbit-broker.
pytest throws two warnings, but has no errors.
2025-04-10 18:48:11.504 [WARNING] (7) endpoint.cc:213 -> Cannot send reply because the service pointer is not set 2025-04-10 18:48:11.506 [WARNING] (7) endpoint.cc:213 -> Cannot send reply because the service pointer is not setunknown if this prevents functionality.
Prior to merging for releases:
CMakeLists.txtfileappVersionto be the new container image tag version inchart/Chart.yaml