Conversation
except python, the tables format aligned neatly.
There was a problem hiding this comment.
Problem
You are modifying README.md, which solves the probelm temporaly. Let me explain what I mean:
- a githubactions workflow runs every day to re-render README.md
- this workflow triggers update_issues.py, which uses README.md.j2 template, inside app/templates/
- then, this re-rendered README.md is published in the main entry of the repository.
With your actual solution, the problem will be solved but just for that day's README file. Next day, when update_issues.py is run again by the githubactions workflow, the problem will persist.
Solution
Instead of modifying README.md, which is only a temporal solution, you should solve the problem from the root cause: the template itself, app/templates/README.md.j2.
- Inside this file, there is a template to render the tables by programming language.
- The problem is in this section:
{% for result in results -%}
### {{result.language}}
| Repo | Title | Comments |
| --- | --- | --- |
{% for issue in result.issues -%}
| {{issue.repo}} | [{{issue.title}}]({{issue.url}}) | {{issue.comments}} |
{% endfor %}
{% endfor %}
- The table is not rendering correctly the issues: instead of creating a table for them, is creating a string with the | symbol concatenating them, but not showing them in a table format, which suggests that the formatting for the table is not correct.
That formatting should be solved.
It shouldn't be a big PR, maybe just a line or two of difference.
|
In case you need guidance to:
Just let me know and we can find a way to talk about it in a more in-depth manner. |
|
Are you still working on this? @lohith1511 |
|
No I am working on other repo’s.
…On Thu, Mar 20, 2025 at 8:00 PM drkrillo ***@***.***> wrote:
Are you still working on this? @lohith1511 <https://github.com/lohith1511>
—
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEJV7C7XZHONW2LFHOF6OZD2VLGIBAVCNFSM6AAAAABXPCDLS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBQGY2TIMRRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: drkrillo]*drkrillo* left a comment (drkrillo/good-first-issues#47)
<#47 (comment)>
Are you still working on this? @lohith1511 <https://github.com/lohith1511>
—
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEJV7C7XZHONW2LFHOF6OZD2VLGIBAVCNFSM6AAAAABXPCDLS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBQGY2TIMRRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@AbiRaja-tech hi there. Sorry for my delay. You can try to solve it. The problem is in the template, not the README. Feel free to try out :) |
except python, the tables format aligned neatly.