Refactor OWASP risk calculation system and improve code organiz…#36
Merged
Refactor OWASP risk calculation system and improve code organiz…#36
Conversation
…ation - Fix real-time risk calculation updates in Analysis component - Implement 1 decimal place formatting for risk values (was showing 2 decimals) - Create centralized risk calculation utilities in utils/riskCalculations.js - Extract textarea helpers to utils/textareaHelpers.js for reusability - Add RiskDisplay component for consistent risk value presentation - Add ResidualRiskSelector component with invisible overlay approach - Remove duplicate functions: createCurrentRiskDisplay, createResidualRiskSelector - Consolidate getRiskValue functions into generic implementation - Clean up unused variables and imports (expandedSections, toggleSection, ThreatCard) - Translate all Spanish comments to English for professional standards - Add ESLint suppressions for appropriate edge cases - Maintain backward compatibility with existing API structure - All 79 frontend tests passing successfully Technical improvements: - Better state management with direct React state references - Modular component architecture with separated concerns - Consistent 1-decimal OWASP risk formatting: (Likelihood + Impact) / 2 - Eliminated ~200 lines of redundant code from Analysis.jsx - Enhanced maintainability and code readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ation
Technical improvements: