Skip to content

feat: invert skill_level scale logic #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drneox merged 1 commit into from
Oct 22, 2025
Merged

feat: invert skill_level scale logic #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions frontend/src/__tests__/components/Analysis.risk-calculations.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,18 +261,18 @@ describe('Analysis Component - Risk Calculations', () => {
});

test('should handle skill level scale correctly', () => {
// Test that the inverted skill level scale works correctly
// Test that the skill level scale works correctly
const skillLevelDescriptions = {
1: 'Habilidades de penetración de seguridad', // Lowest risk (expert required)
3: 'Habilidades de red y programación',
1: 'Sin habilidades técnicas', // Highest risk (anyone can do it)
3: 'Algunas habilidades técnicas',
5: 'Usuario avanzado de computadoras',
6: 'Algunas habilidades técnicas',
9: 'Sin habilidades técnicas' // Highest risk (anyone can do it)
6: 'Habilidades de red y programación',
9: 'Habilidades de penetración de seguridad' // Lowest risk (expert required)
};

// Verify the scale is inverted (higher value = easier to execute = higher risk)
expect(skillLevelDescriptions[9]).toContain('Sin habilidades');
expect(skillLevelDescriptions[1]).toContain('penetración');
// Verify the scale (higher value = more skills required = lower risk)
expect(skillLevelDescriptions[1]).toContain('Sin habilidades');
expect(skillLevelDescriptions[9]).toContain('penetración');
});
});

Expand Down
10 changes: 5 additions & 5 deletions frontend/src/__tests__/hooks/useLocalization.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ describe('getOwaspSelectOptions', () => {
values: {
skill_level: {
"0": "N/A",
"1": "Habilidades de penetración de seguridad",
"3": "Habilidades de red y programación",
"1": "Sin habilidades técnicas",
"3": "Algunas habilidades técnicas",
"5": "Usuario avanzado de computadoras",
"6": "Algunas habilidades técnicas",
"9": "Sin habilidades técnicas"
"6": "Habilidades de red y programación",
"9": "Habilidades de penetración de seguridad"
},
motive: {
"0": "N/A",
Expand All @@ -99,7 +99,7 @@ describe('getOwaspSelectOptions', () => {
});
expect(options[5]).toEqual({
value: 9,
label: '9 - Sin habilidades técnicas'
label: '9 - Habilidades de penetración de seguridad'
});
});

Expand Down
8 changes: 4 additions & 4 deletions frontend/src/__tests__/integration/Analysis.integration.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ jest.mock('../../hooks/useLocalization', () => ({
changeLanguage: jest.fn()
}),
getOwaspSelectOptions: jest.fn().mockReturnValue([
{ value: 1, label: '1 - Habilidades de penetración de seguridad' },
{ value: 3, label: '3 - Habilidades de red y programación' },
{ value: 1, label: '1 - Sin habilidades técnicas' },
{ value: 3, label: '3 - Algunas habilidades técnicas' },
{ value: 5, label: '5 - Usuario avanzado de computadoras' },
{ value: 6, label: '6 - Algunas habilidades técnicas' },
{ value: 9, label: '9 - Sin habilidades técnicas' }
{ value: 6, label: '6 - Habilidades de red y programación' },
{ value: 9, label: '9 - Habilidades de penetración de seguridad' }
])
}));

Expand Down
8 changes: 4 additions & 4 deletions frontend/src/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
"values": {
"skill_level": {
"0": "N/A",
"1": "Security penetration skills",
"3": "Network and programming skills",
"1": "No technical skills",
"3": "Some technical skills",
"5": "Advanced computer user",
"6": "Some technical skills",
"9": "No technical skills"
"6": "Network and programming skills",
"9": "Security penetration skills"
},
"motive": {
"0": "N/A",
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/locales/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
"values": {
"skill_level": {
"0": "N/A",
"1": "Habilidades de penetración de seguridad",
"3": "Habilidades de red y programación",
"1": "Sin habilidades técnicas",
"3": "Algunas habilidades técnicas",
"5": "Usuario avanzado de computadoras",
"6": "Algunas habilidades técnicas",
"9": "Sin habilidades técnicas"
"6": "Habilidades de red y programación",
"9": "Habilidades de penetración de seguridad"
},
"motive": {
"0": "N/A",
Expand Down