Prompt for PostgreSQL username and password instead of using configuration, and check that the user exists #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 11, 2012 23:52
…_file to callback Signed-off-by: Craig S. Cottingham <craig.cottingham@hrworx.com>
Signed-off-by: Craig S. Cottingham <craig.cottingham@hrworx.com>
| @@ -16,6 +29,11 @@ | |||
| task :populate => :sample | |||
| end | |||
| RUBY | |||
| end | |||
| rescue PG::Error => err | |||
| # surely there's a better way to report errors than this.... | |||
There was a problem hiding this comment.
Perhaps put the ask_wizard in a while loop until they give valid credentials?
There was a problem hiding this comment.
Yeah, maybe. It doesn’t help when there are no valid credentials, but making the user ctrl-C or switch to another command prompt to create the user isn’t any worse than this.
Signed-off-by: Craig S. Cottingham <craig.cottingham@hrworx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one thing I’m not happy with is lines 34-36. I don’t know how to properly report an error, so I’m just printing to stdout and exiting.