Open
Conversation
New json format
Add event listener tracking
Still need to make censors selectable, draggable and resizable
… move with height of player
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bringing in updated code to make IC player compatible with electron 33. The main files changes were app.js which brings in the new preload.js script. preload.js contains a function that allows us to get a file's path after the .path method was deprecated in electron v31. app.js also contains a change to turn contextIsolation off by default because our app doesn't run with it on. It was turned on by default in electron 12. Changes made to renderer/player.js are mostly due to the .path method swap for the new method.