Skip to content
This repository was archived by the owner on Mar 15, 2018. It is now read-only.

Allow non-global Stripe key configuration#14

Open
jkassemi wants to merge 7 commits intodrone:masterfrom
jkassemi:master
Open

Allow non-global Stripe key configuration#14
jkassemi wants to merge 7 commits intodrone:masterfrom
jkassemi:master

Conversation

@jkassemi
Copy link

@jkassemi jkassemi commented Jul 5, 2013

I'd like the possibility of using this library in environments with Client objects outside of the default set, which this change allows.

client := &PlanClient{ Client{key: "non-default"} }
client.List() // Use 'non-default' as key.

@jkassemi
Copy link
Author

And because I worked a little later than I should - added feature: account endpoint!

I know this makes this pull request undeniable, but if you do want to see these features separated I can do that ;)

@bradrydzewski
Copy link
Contributor

awesome! I've been meaning to remove the global key, so this is definitely a welcome change. I'm definitely going to merge this but first I need to run a bunch of regression tests against drone.io just to be safe. Bear with me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants