Skip to content

Supports Android O NotificationChannel #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Supports Android O NotificationChannel #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion ClientLib/src/main/java/org/droidplanner/services/android/impl/api/DroidPlannerService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
package org.droidplanner.services.android.impl.api;

import android.annotation.SuppressLint;
import android.annotation.TargetApi;
import android.app.Notification;
import android.app.NotificationChannel;
import android.app.NotificationManager;
import android.app.Service;
import android.content.ComponentName;
import android.content.Context;
import android.content.Intent;
import android.content.pm.PackageManager;
import android.os.Build;
import android.os.Handler;
import android.os.IBinder;
import android.os.Looper;
Expand Down Expand Up @@ -215,12 +219,33 @@ public void onCreate() {
updateForegroundNotification();
}

@TargetApi(Build.VERSION_CODES.O)
private NotificationChannel createNotificationChannel(final String channelId) {
final NotificationChannel notificationChannel = new NotificationChannel(channelId, "DroneKit-Android", NotificationManager.IMPORTANCE_DEFAULT);
notificationChannel.enableLights(false);
notificationChannel.enableVibration(false);
notificationChannel.setImportance(NotificationManager.IMPORTANCE_LOW);

return notificationChannel;
}

@SuppressLint("NewApi")
private void updateForegroundNotification() {
final Context context = getApplicationContext();

final String channelId = "DroneKit-Android_default_id";

if(Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
final NotificationChannel channel = createNotificationChannel(channelId);
final NotificationManager manager = ((NotificationManager)getSystemService(Context.NOTIFICATION_SERVICE));
if(manager != null)
manager.createNotificationChannel(channel);
else
return;
}

//Put the service in the foreground
final NotificationCompat.Builder notifBuilder = new NotificationCompat.Builder(context)
final NotificationCompat.Builder notifBuilder = new NotificationCompat.Builder(context, channelId)
.setContentTitle("DroneKit-Android")
.setPriority(NotificationCompat.PRIORITY_MIN)
.setSmallIcon(R.drawable.ic_stat_notify);
Expand Down