Add SNR estimator spot tests for RADE V1 AWGN channel#67
Merged
Conversation
Owner
drowe67
commented
Mar 13, 2026
drowe67
commented
- test/check_snr.py: reads radae_rxe.py verbose output, averages SNRdB over last N sync frames, checks against expected SNR3k within tolerance
- CMakeLists.txt: radae_snr_est_high (EbNodB 10, SNR3k 8.24 dB ±2 dB) and radae_snr_est_low (EbNodB 5, SNR3k 3.24 dB ±2 dB)
- test/check_snr.py: reads radae_rxe.py verbose output, averages SNRdB over last N sync frames, checks against expected SNR3k within tolerance - CMakeLists.txt: radae_snr_est_high (EbNodB 10, SNR3k 8.24 dB ±2 dB) and radae_snr_est_low (EbNodB 5, SNR3k 3.24 dB ±2 dB) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
tmiw
reviewed
Mar 13, 2026
| python3 loss.py features_in.f32 features_rx_out.f32 --loss 0.3 --acq_time_test 1.0 --clip_end 300") | ||
| set_tests_properties(radae_rx_awgn PROPERTIES PASS_REGULAR_EXPRESSION "PASS") | ||
|
|
||
| # SNR estimator spot tests: check radae_rxe.py reports SNR3k within 3 dB of inference.sh target |
Collaborator
There was a problem hiding this comment.
Does tolerance need to be set lower? The SNR values on the C port seemed to be higher but not necessarily high enough to meet this threshold.
Owner
Author
There was a problem hiding this comment.
3dB was required to pass the test on GitHub, see ee70232 for the Python version.
Collaborator
There was a problem hiding this comment.
Fair enough. We can see how this works once we port this test to the C version. 👍
tmiw
approved these changes
Mar 14, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.