Revert incorrect Rwalk changes, introduce additional test#34
Open
zakkor wants to merge 4 commits intodroyo:masterfrom
Open
Revert incorrect Rwalk changes, introduce additional test#34zakkor wants to merge 4 commits intodroyo:masterfrom
zakkor wants to merge 4 commits intodroyo:masterfrom
Conversation
If the name already existed, then there's no need to Put it, otherwise it gets set inside the Do call, which also means there's no need to Put it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts incorrect changes introduced in #30, which broke Rwalk (for which there were failing tests that went unnoticed).
Also removes a superfluous Put call in qidpool: if it already exists, there's no need to Put it, otherwise it gets handled inside the Do block, so still no need for a Put.
In the #30 PR, @seh-msft says:
In the case of a new file being created in the tree, a Twalk, then a Tcreate, would occur.
If there's a new file being created, that means the file doesn't exist yet, which means the Twalk should fail. In the event of an unsuccessful Twalk, no new Qid should be created. I've added a new test that verifies this behaviour is true.
Tcreate should be the only origin of 'new' QIDs to the core file system.
Considering the above, this is still true: Twalk fails, no Qid is created, then Tcreate occurs, and the Qid and file get created.
In conclusion, the current behaviour is correct, so this PR reverts back to that -- there was no need for a fix. I am not sure what issues the original submitter was facing, but I am guessing that they were not coming from styx.
Resolves #31