fix: use loose semver to eliminate unnecessary errors #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently used patch-package in production, and I got the “Version string cannot be parsed” error because one of my npm packages had the version 0.10.1a in its package.json. Specifically, this was the “mathquill” npm package. The “a” at the end of the version number was causing the error. As a result, patch-package was unable to patch this npm package when doing a fresh npm install and postinstall.
I propose using the “loose” option when checking if the semantic version of an npm package is valid. In my tests using the “loose” option, the mathquill npm package with version 0.10.1a was correctly given a patch with version 0.10.1-a.