Fix for Coco 0.7.6, path.exist -> fs.exist. New Dust engine.#9
Open
rektide wants to merge 4 commits intodsc:masterfrom
Open
Fix for Coco 0.7.6, path.exist -> fs.exist. New Dust engine.#9rektide wants to merge 4 commits intodsc:masterfrom
rektide wants to merge 4 commits intodsc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there. Sorry, I didn't know pull requests off a single branch would have such poor granularity: I would've done feature branches had I known. The changes are all very small, mercifully & safe.
The first two commits address Coco 0.7.6 removing + as an Array concatenator. The issue for that is:
#7
rektide@f96dbbe
The third commit implements (fs.exists || path.exists) to handle node's migration of this API item. The issue for that is:
#6
You are correct in your assesment:
#6 (comment)
rektide@57ca095
The fourth commit is a feature, support for compiling Dust.js templates. This will work with nearly any dust version, but the best maintained atm is LinkedIn's. The issue for this is:
#8
rektide@206c35b
Thank you very much for developing and maintaining this epic library. If I can assist you with any of these issues, please let me know how I can help.