MongoFrei #344
Merged
MongoFrei #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Coverage report
Click to see where and how coverage changed
The report is truncated to 25 files out of 55. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
server/lomas_server/administration/tests/test_streamlit_app_page_b.py
Outdated
Show resolved
Hide resolved
Comment on lines
+181
to
+198
| dp_querier: DPQuerier | ||
| match dp_library: | ||
| case DPLibraries.SMARTNOISE_SQL: | ||
| query_model = SmartnoiseSQLDummyQueryModel.model_validate_json(query_model_str) | ||
| data_connector = await get_dummy_dataset_for_query(admin_database, query_model) | ||
| dp_querier = SmartnoiseSQLQuerier(data_connector, admin_database) | ||
| case DPLibraries.SMARTNOISE_SYNTH: | ||
| query_model = SmartnoiseSynthDummyQueryModel.model_validate_json(query_model_str) | ||
| data_connector = await get_dummy_dataset_for_query(admin_database, query_model) | ||
| dp_querier = SmartnoiseSynthQuerier(data_connector, admin_database) | ||
| case DPLibraries.OPENDP: | ||
| query_model = OpenDPDummyQueryModel.model_validate_json(query_model_str) | ||
| data_connector = await get_dummy_dataset_for_query(admin_database, query_model) | ||
| dp_querier = OpenDPQuerier(data_connector, admin_database) | ||
| case DPLibraries.DIFFPRIVLIB: | ||
| query_model = DiffPrivLibDummyQueryModel.model_validate_json(query_model_str) | ||
| data_connector = await get_dummy_dataset_for_query(admin_database, query_model) | ||
| dp_querier = DiffPrivLibQuerier(data_connector, admin_database) |
Member
There was a problem hiding this comment.
would be nice as a function to avoid having 3 times the same code
Collaborator
Author
There was a problem hiding this comment.
at the time there was only two (with 2 smartnoise gone) but back-porting it we could
| @@ -0,0 +1,465 @@ | |||
| import logging | |||
Member
There was a problem hiding this comment.
It seems all good, I just wonder how can you be sure that there is a lock and no worker can read while another worker is writing?
PaulineMauryL
approved these changes
Nov 11, 2025
Member
PaulineMauryL
left a comment
PaulineMauryL
left a comment
There was a problem hiding this comment.
I just have a few understanding questions but very interesting PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.