Skip to content

AddsDomain: Add 32k page option #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

AddsDomain: Add 32k page option #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79323c5
Move docs to separate task
dan-hughes Sep 18, 2025
24de1d8
Add new 32k db page option
dan-hughes Sep 18, 2025
7e2c4b7
Update test
dan-hughes Sep 18, 2025
981ff6c
Update changelog
dan-hughes Sep 18, 2025
c5f6958
Update changelog
dan-hughes Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- `AddsDomain`:
- Added `Enable32KDatabasePages` parameter.

### Changed

- DscPullServer:
Expand All @@ -26,6 +31,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `GPRegistryPolicyDsc` to `1.3.1`.
- `SharePointDSC` to `5.6.1`.
- `ConfigMgrCBDsc` to `4.0.0`.
- build.yml
- Moved documentation tasks to separate step to speed up local builds.

### Fixed

Expand Down
5 changes: 4 additions & 1 deletion build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,15 @@ BuildWorkflow:
- Build_Module_ModuleBuilder
- Build_NestedModules_ModuleBuilder
- Create_Changelog_Release_Output
- FixEncoding

docs:
- Generate_Conceptual_Help
- Generate_Wiki_Content
- FixEncoding

pack:
- build
- docs
- package_module_nupkg

hqrmtest:
Expand Down
17 changes: 16 additions & 1 deletion source/DSCResources/AddsDomain/AddsDomain.schema.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ configuration AddsDomain

[Parameter()]
[boolean]
$EnablePrivilegedAccessManagement = $false
$EnablePrivilegedAccessManagement = $false,

[Parameter()]
[boolean]
$Enable32KDatabasePages = $false
)

Import-DscResource -ModuleName PSDesiredStateConfiguration
Expand Down Expand Up @@ -142,6 +146,17 @@ configuration AddsDomain
}
}

if ( $Enable32KDatabasePages -eq $true )
{
ADOptionalFeature ADDatabase32KPagesFeature
{
DependsOn = "[ADGroup]EnterpriseAdmins_$DomainName"
ForestFQDN = $DomainFQDN
EnterpriseAdministratorCredential = $DomainAdministrator
FeatureName = 'Database 32k pages feature'
}
}

foreach ($trust in $DomainTrusts)
{
WaitForAdDomain $trust.Name
Expand Down
1 change: 1 addition & 0 deletions tests/Unit/DSCResources/Assets/Config/AddsDomain.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ SysvolPath: C:\WindowsTest\SYSVOL
ForestMode: Win2012R2
ForceRebootBefore: true
EnablePrivilegedAccessManagement: true
Enable32KDatabasePages: true
DomainTrusts:
Fqdn: northwindtraders.com
Name: northwindtraders
Expand Down