Fix footer canonical URL in liquid template#27
Merged
Conversation
EdgeUrl is a plain string property, not a TextField — remove .Text accessor so the stored canonical URL renders correctly instead of resolving to the current page. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes rendering of the canonical source URL in the AutoBlog post footer by treating EdgeUrl as a plain string (instead of a TextField), and bumps the module’s displayed version.
Changes:
- Update
Content-AutoBlogPost.liquidto useautoblogPart.EdgeUrldirectly (remove.Text) for the footer canonical link. - Bump
Constants.Versionfrom1.6.4to1.6.5.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/IgniteSG.OrchardCore.MspMarketingEdge/Views/Content-AutoBlogPost.liquid |
Fix footer link to render stored canonical URL string correctly. |
src/IgniteSG.OrchardCore.MspMarketingEdge/Constants.cs |
Update displayed module version constant. |
src/IgniteSG.OrchardCore.MspMarketingEdge/Views/Content-AutoBlogPost.liquid
Show resolved
Hide resolved
EdgeUrl originates from an external feed and is rendered directly into an href attribute. Without scheme validation a compromised feed could inject javascript: or other dangerous URIs. Validate with Uri.TryCreate at the storage boundary (ResolveCanonicalUrlAsync) and also re-validate previously-stored values in the update path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EdgeUrlis a plainstringproperty onAutoBlogPart, not aTextField— removed.Textaccessor so the stored canonical URL renders correctly in the post footer instead of falling back to an empty href (which browsers resolve to the current page URL)Test plan
yourtechupdates.com/...) not the local site URL🤖 Generated with Claude Code