Merged
Conversation
Update main.workflow.yml
annawoodard
approved these changes
Apr 30, 2025
Collaborator
annawoodard
left a comment
There was a problem hiding this comment.
wonderful thank you @collin-k!!!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses code readability and maintainability.
Changes
config.REGULARIZATION_TYPEandconfig.REGULARIZATION_WEIGHTin thetrain_epochfunction intrain.pyare now passed as flat parameters rather than as a tuple.KaneCountyandRiverDatsetclasses were revised to be passed as individual parameters arguments rather than as a tuple. The code to instantiateKaneCountyandRiverDatasetwithintrain.py(in theinitialize_datasetfunction) was changed accordingly. The docstrings within each class was revised accordingly.KaneCountyandRiverDatasetwere changed to instance variable usingself.The docstrings within each class was revised accordingly.BalancedRandomBatchGeoSamplerandBalancedGridGeoSamplerclasses were revised to be passed as individual parameters arguments rather than as a dictionary. The code to instantiateBalancedRandomBatchGeoSamplerandBalancedGridGeoSamplerwithintrain.py(in thebuild_dataloaderfunction) was partially changed accordingly (only lines 224-233. The docstrings within each class was revised accordingly.