Fix: !ignore tags in !merge and !flatten tags#23
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes !ignore tag handling inside !merge and !flatten tags by filtering out undefined values (produced by !ignore) during document processing.
Changes:
- Filter out
undefineditems (from!ignoretags) inprocessParsedDocumentfor bothFlattenandMergenodes - Add test coverage for
!ignorewithin!flattenand!mergesequences - Bump spec version badge from v0.2.8-0 to v0.2.8-1
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/parser.ts | Filter out undefined values when processing Flatten and Merge node items |
| test/resolver.test.ts | Add tests for !ignore in !flatten and !merge contexts |
| README.md | Update spec version badge to v0.2.8-1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to be spec-compliant with dsillman2000/yaml-reference-specs#31