ci: enable test execution for non-UI test modules #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace GitHub Action PMD with Maven-based PMD job for version consistency with ddk-parent/pom.xml. Add separate Checkstyle job. Both run in parallel with maven-verify for faster feedback on style violations. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The cast clarifies that ProxyModelAssociationsAdapter is an Adapter through its inheritance chain. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove AllTests.java and XtextTestSuite.java - JUnit 5 @SelectPackages doesn't work with OSGi bundleresource:// URIs - Add <includes> pattern for *Test.java in tycho-surefire-plugin - Let Tycho discover tests by naming convention instead - Remove ExportScopingTest.xtext (was added for testing, not in master)
- Rename BugAig1314, BugDsl27, BugAig1084 to *Test suffix so they match
JUnit 5 default class name pattern and Tycho's **/*Test.java convention
- Add missing expression package to GeneratorTestSuite @SelectPackages
- Add @IncludeClassNamePatterns(".*Test.*") to all suites for consistency
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…sses Fix PMD PublicMemberInNonPublicType violations: constructors, methods, fields, and inner classes that were still public in package-private test classes are now package-private. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enable test execution for 7 non-UI test modules that have been skipped since the initial open-source contribution (2016). The parent POM has <skip>true</skip> for tycho-surefire-plugin, and only xtext.test overrode it. Modules enabled: - com.avaloq.tools.ddk.typesystem.test - com.avaloq.tools.ddk.check.core.test - com.avaloq.tools.ddk.check.runtime.core.test - com.avaloq.tools.ddk.checkcfg.core.test - com.avaloq.tools.ddk.xtext.export.test - com.avaloq.tools.ddk.xtext.format.test - com.avaloq.tools.ddk.xtext.generator.test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
Summarizes test results from enabling tycho-surefire for 7 non-UI test modules. 3 modules pass cleanly (+85 tests), 3 need UI harness, 1 has a genuine test setup bug. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
xtext.test was skipped by Maven due to earlier failures, not actually executed. Corrected total from 283 to 209 tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<skip>true</skip>fortycho-surefire-pluginglobally, and onlyxtext.testhad overridden itModules enabled
typesystem.testcheck.core.testcheck.runtime.core.testcheckcfg.core.testxtext.export.testxtext.format.testxtext.generator.testConfiguration
Each module gets a minimal tycho-surefire override:
<skip>false</skip>to enable test execution<includes>**/*Test.java</includes>for Tycho test discovery<useUIThread>false</useUIThread>— these are non-UI tests<failIfNoTests>false</failIfNoTests>as safety netTest plan
🤖 Generated with Claude Code