[Internal]: Replace Instance.termination_reason values with codes
#3187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r4victor
reviewed
Oct 14, 2025
src/dstack/_internal/server/background/tasks/process_running_jobs.py
Outdated
Show resolved
Hide resolved
r4victor
reviewed
Oct 14, 2025
r4victor
reviewed
Oct 15, 2025
Comment on lines
+617
to
618
| # TODO: Migrate to EnumAsString(InstanceTerminationReason, 100) after enough releases to ensure backward compatibility | ||
| termination_reason: Mapped[Optional[str]] = mapped_column(String(4000)) |
There was a problem hiding this comment.
What happens after enough releases? Old instances continue to have non-enum values forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3182