Add lambda glyph, add italic styles, fix errors#13
Open
kaBeech wants to merge 1 commit intodtinth:masterfrom
Open
Add lambda glyph, add italic styles, fix errors#13kaBeech wants to merge 1 commit intodtinth:masterfrom
kaBeech wants to merge 1 commit intodtinth:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Thai!
Thanks for your patience with all the times I've accidentally opened Pull Requests to your repo when working on my fork 😅
This time, though, I did it on purpose - I figure it's time to share some improvements I've made that are relevant to Comic Mono 😸
This PR includes italicized styles, a lambda 'λ' glyph, and some error fixes (mostly points missing at extrema).
Importantly, it does not include my edits to disambiguate certain glyphs (currently 'a'/'o', 'l'/'1', and 'Y'/'y'). In my mind it seems sensible to keep Comic Mono close to the original without messing with these glyphs, but if you think differently and would like to use them then I'd be happy to share them!
It also doesn't include the light styles, mostly because that's a little more work than I want to put into this project today, and I don't know whether you're interested in them anyway, but if you would like them I can send them over when I have a bit more time as well 😸
Of course, if you would like a subset of these changes (for example, the lambda glyph but not the error fixes), I'd be happy to make a PR with your selected changes only.
Thanks for your work on this awesome project!