Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was doing a live rebuild on my gentoo system when I saw that this package was updated. I went and checked and noticed that there is a gentoo overlay listed for it now. I have had this packaged on my overlay for quite a while now. The gentoo package which is advertised in the README is extremely poorly made.
This ebuild would throw a dozen errors in something like
pkgcheck, which is gentoo's utility checking the syntax for ebuilds to ensure they are properly written.LICENSE="MIT License"is wrong, according to SPDX it should beLICENSE="MIT", and this will lead to the software being unable to be installed unless you accept the license manually by editing/etc/portage/package.license(gentoo sees it as a proprietary package). Furthermore, it's a 9999 ebuild, so similar to -git on AUR, yet it is pulling a particular commit to buildThis also violates gentoo policy regarding how things can be packaged, a 9999 ebuild must provide the latest commit of a package using
git-r3eclass (or whatever source control is being used) which mine does. There is also a leading space and unicode characters inDESCRIPTION,DESCRIPTIONis too long, there is an emptyIUSEfor no reason, and so on. There is also lots of fluff lines that are entirely unnecessary and do nothing.I regularly ensure my ebuilds are properly formatted and have no syntax errors or more severe errors, especially not things as egregious as these. I advise you to merge this PR to resolve all these problems, thanks. Have a nice day.