Изменена метка. Добавлен признак что это ZIP, а не просто набор данных#137
Изменена метка. Добавлен признак что это ZIP, а не просто набор данных#137
Conversation
WalkthroughUpdated the visible label of a download link in templates/opendata.html to indicate a .geojson.zip file; the href already pointed to the .zip file. No logic or structural changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
templates/opendata.html (3)
79-79: Localize the link text for consistency with the page.Most nearby strings use
{% trans %}. Wrap the anchor text to keep i18n consistent.- class="button">Скачать .geojson.zip</a></td> + class="button">{% trans 'Скачать .geojson.zip' %}</a></td>
79-79: Hint: suggest a filename via the download attribute.Improves UX if Content-Disposition isn’t set server-side.
- <td class="text-center"><a href="/media/opendata/{{ opendata_item.region.slug }}.geojson.zip" - class="button">{% trans 'Скачать .geojson.zip' %}</a></td> + <td class="text-center"><a href="/media/opendata/{{ opendata_item.region.slug }}.geojson.zip" + download="{{ opendata_item.region.slug }}.geojson.zip" + class="button">{% trans 'Скачать .geojson.zip' %}</a></td>
79-79: Optional a11y: add an aria-label with context.If you want screen readers to announce region/period alongside “download”, add an aria-label (requires blocktrans due to variables).
Example (not a required change):
<a ... aria-label="{% blocktrans with r=opendata_item.region.name sd=start_date|date:'F Y'|lower ed=opendata_item.date|date:'F Y'|lower %}Скачать архив GeoJSON (.zip) — {{ r }} ({{ sd }}–{{ ed }}){% endblocktrans %}">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
templates/opendata.html(1 hunks)
🔇 Additional comments (1)
templates/opendata.html (1)
79-79: Label clarity improved — good change.The visible label now accurately indicates a ZIP archive. Matches the PR objective.
Summary by CodeRabbit