feat: add graceful degradation on LLM failure #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements cascading fallback strategy: Full → Reduced (Haiku) → Gates-only → Minimal Always produces output, never fails silently. - DegradationLevel enum with 4 levels - DegradedReviewPipeline wraps LLM calls with fallback - format_degraded_review for GitHub comment output - Updated main.py to use degradation pipeline - Updated existing tests to use new pipeline mocking Implements #34 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dtsong
added
resiliency
- Restore retry/backoff logic within each degradation level using retry_with_adaptation (was dropped entirely in initial impl) - Use config.llm.simple_model for reduced fallback instead of hardcoded invalid "haiku" string - Reuse single LLMReviewer instance across levels - Remove unreachable MINIMAL level (gate_results can't fail) - Move format_degraded_review import to top-level in main.py - Remove dead FULL/REDUCED branches from format_degraded_review (main.py already routes those through format_as_markdown) - Display accumulated errors in degraded comment output Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Degradation pipeline already uses retry_handler internally, so our branch's higher-level abstraction supersedes main's direct usage. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
Summary
Changes
src/pr_review_agent/execution/degradation.py- DegradationLevel enum + DegradedReviewPipelinetests/test_degradation.py- 14 tests covering all scenariossrc/pr_review_agent/main.py- Uses degradation pipeline instead of raw retrysrc/pr_review_agent/output/github_comment.py- Addedformat_degraded_review()tests/test_main.py- Updated mocks for new pipelineTest Plan
🤖 Generated with Claude Code