Curve 2crv Strat: first release to Arbitrum#6
Curve 2crv Strat: first release to Arbitrum#6pata-eth wants to merge 23 commits intodudesahn:arbitrum-2crvfrom
Conversation
|
converted this one to draft until we sort out the reward claim process for all new curve gauges. |
pata-eth
changed the title
|
@poolpitako and @dudesahn, given the material changes of the commit I just pushed, we may want to have poolpi review its diff so that he can confirm he still approves the PR as it currently stands. Thank you both! |
|
|
|
Thanks again, for the feedback @dudesahn ! I've fixed my linter and updated the code according to your feedback. We still have a few open conversations unresolved, but I think this is ready for @poolpitako's final review. I may submit one more change based on how we resolve our pending items. Thank you |
|
|
|
you can delete this line since you don't call that function anywhere |
|
non-blocking, but in the future I would encourage you to use natspec for your comments of functions/state vars—that way they show up nicely on etherscan. I did this for my most recent iteration of strategies and am pretty happy with it. |
|
Also, I think you can delete lines 16 and 18, as these are already inherited from the baseStrategy. again, not a big deal tho. |
|
LGTM as my comments are non-blocking |
Absolutely. In my new projects I'm already incorporating natspec. So much better! |
Do you know why we can remove these lines but not lines 6 and 7? |
|
you should be able to remove those as well :) |
2 participants
FWIW, my 'arbitrum-2crv' branch was created from the 'arbitrum-tricrypto' branch, but I noticed that your 'arbitrum-2crv' branch was created from main. I didn't notice any material differences in the 'diff'. I look forward to your feedback. Thank you!
Issue: https://github.com/yearn/yearn-strategies/issues/276