Open
Conversation
pata-eth
commented
May 18, 2022
|
|
||
| # specifically check that our gain is greater than our donation or confirm we're no more than 5 wei off. | ||
| assert new_params["totalGain"] - prev_params["totalGain"] > donation | ||
| assert new_params["totalGain"] - prev_params["totalGain"] >= donation |
Author
There was a problem hiding this comment.
none of the tests make money because the gauge is not currently receiving any CRV or third-party reward token. I've added the '=' so that the test passes.
pata-eth
changed the title
Author
|
@poolpitako, this is ready for your review |
pata-eth
force-pushed
the
geist
branch
2 times, most recently
from
aeb14c7 to
dd4e362
Compare
Author
|
|
poolpitako
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@poolpitako, I've created a draft PR so that you can begin your review of the changes so far. They are minimal as you'll quickly find out. The PR is in draft mode as I'm still investigating the mechanics of the new gauges. I suspect that the way we used to claim rewards with the old gauges is no longer valid with the new ones. I'll keep you posted.