refactor(par_core): simplify join
#87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kdy1
added a commit
to swc-project/swc
that referenced
this pull request
Jun 19, 2025
**Description:**
This PR is a breaking change of `swc_ecma_utils` because users of the
crate need to update their `Cargo.toml` like
from
```toml
par-core = { version = "1", features = ["chili"] }
```
to
```toml
par-core = { version = "2", features = ["chili"] }
```
**Related issue:**
- dudykr/ddbase#87
- Closes #10453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes swc-project/swc#10453
I learnt that the basic idea of
par_coreis passing&mut Scopedown by thread local variables. I think the original code is verbose and causes some bugs like swc-project/swc#10453. So here I provide a simpler and more intuitive implementation.Before:
After:
Help me test if there's any bug (like panic) or performance regression.
This is a breaking change since I remove some public api (although I think they should not be public at all).