feat: Add cow-replace
#89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new crate called "cow-replace" for string replacement with Cow and aligns dependency management across related crates.
- Introduces the "cow-replace" crate with workspace inherited metadata and build settings.
- Updates dependency definitions for rkyv and serde in the "bytes-str" crate to use workspace references.
- Adds an ascii dependency version to the top-level Cargo.toml.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/cow-replace/Cargo.toml | New crate configuration with workspace-based settings. |
| crates/bytes-str/Cargo.toml | Updates dependency declarations to reference workspace versions. |
| Cargo.toml | Adds the ascii dependency with a fixed version. |
| repository = { workspace = true } | ||
| version = "0.1.1" | ||
|
|
||
| [features] |
There was a problem hiding this comment.
[nitpick] The [features] section is currently empty; consider removing it until features are implemented to simplify the configuration.
Suggested change
| [features] |
| tracing-subscriber = "0.3.19" | ||
| triomphe = "0.1.14" | ||
| url = "2.5.4" | ||
| bytes = "1.10.1" |
There was a problem hiding this comment.
[nitpick] Ensure that the explicit ascii dependency version here is consistent with workspace-managed versions used in other crates to avoid conflicts.
Suggested change
| bytes = "1.10.1" | |
| bytes = "1.10.1" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for swc-project/swc#10665