Fix chaining with pure javascript async func#8
Open
d3m3vilurr wants to merge 4 commits intoduereg:masterfrom
Open
Fix chaining with pure javascript async func#8d3m3vilurr wants to merge 4 commits intoduereg:masterfrom
d3m3vilurr wants to merge 4 commits intoduereg:masterfrom
Conversation
``` TypeError: this.that[key].promise.apply is not a function at Object.async (src/songbird.coffee:52:26) at Context.<anonymous> (test/songbird.spec.js:15:23) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support
async functionif we use the
babelfor it, async function should transpiled toGenerateFunction.but async function occurs the
TypeError;support class method
finding class method should do more complex calculation than
Object.keysto fetch methods of super class.