Fix address calculation in ulp_run() call in all examples #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks, I'll take a look at this in a few days. |
Author
|
Ping ping. I have double-triple-verified this one before opening this PR. |
Owner
|
Thanks again I'm just in the middle of another project that I need to finish, hopefully soon and I will get back to ulp stuff then. Hold tight I'll be looking at this first. |
|
Agree - this fixes the i2c example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FAQ
But all the examples work without this change?
When entry is the first record in the code,
&ulp_entry - RTC_SLOW_MEM == 0, so any multiplication or division is still 0. However if you add code before ulp_entry you end up at the wrong address.What do the official docs say?
ESP_ERROR_CHECK( ulp_run(&ulp_entry - RTC_SLOW_MEM) );See here