Better method for python3 compatibility #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.python.org/2.7/library/subprocess.html#subprocess.Popen.communicate The universal_newlines argument is equivalent to text and is provided for backwards compatibility. By default, file objects are opened in binary mode.
Author
|
realised that the previous error can be solved by copying files using platforms.local.txt hooks |
Arduino doesn't seem to be copying the .s files from the sketch directory to the temp directory. This causes the following errors: `undefined reference to 'ulp_count'` `undefined reference to 'ulp_entry'`.
codeleger
approved these changes
Feb 10, 2022
codeleger
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/2.7/library/subprocess.html#subprocess.Popen.communicate
https://docs.python.org/3.8/library/subprocess.html#subprocess.Popen.communicate
The universal_newlines argument is equivalent to text and is provided for backwards compatibility. By default, file objects are opened in binary mode.
This fixes the
TypeError: can only concatenate str (not "bytes") to str(for error_string = cmd[0] + '\r' + err)
and also the
TypeError: write() argument must be str, not bytes(for fsym.write(out))