test(cli): expand offline e2e coverage for service integrity and lifecycle#47
Open
Ethan-Dunia wants to merge 2 commits intomainfrom
Open
test(cli): expand offline e2e coverage for service integrity and lifecycle#47Ethan-Dunia wants to merge 2 commits intomainfrom
Ethan-Dunia wants to merge 2 commits intomainfrom
Conversation
Replace brittle text substring checks ("1 enabled", "0 stored",
"Run 'kimbap link github' to connect.") with a structured assertion
against the status --format json contract, and keep only the CLI
command fragment "kimbap link github" as the footer check. The JSON
schema is stable across copy changes; the command fragment is CLI
syntax rather than prose.
Author
Guarded commits / contractsMapping each added test to the concrete recent fix or contract it locks in, so future regressions in these paths surface as CI failures rather than user bug reports.
Follow-up (intentionally out of scope)
Follow-up commit on this branch
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
service validate/sign/verifystatusguidanceWhy
The existing
cmd/kimbap/e2e_test.gosuite covered a few golden-path CLI flows, but it did not exercise the newer v0.2.x service integrity surface or stateful service lifecycle transitions.This PR keeps the default e2e suite focused on deterministic, offline CLI behavior and closes the most obvious coverage gaps without introducing GUI/TCC-dependent instability.
Scope
Included:
cmd/kimbap/e2e_test.gocmd/kimbap/service_lifecycle_test.goOut of scope:
darwin && integrationAppleScript GUI testsI intentionally left the GUI AppleScript integration suite out of this PR. That path has different ergonomics and reliability constraints (TCC prompts, app launch timing, local app state) and should be proposed separately as an opt-in integration-testing change.
Validation
go test ./cmd/kimbap -run '^TestE2E' -count=1(2 fresh rounds after the final e2e additions)go test ./cmd/kimbap -count=1go test ./...Notes
I first attempted to push via the local work SSH key (
~/.ssh/id_ed25520, thekompas.aikey), but bothgithub.com:22andssh.github.com:443were closed by the remote/network path on this machine. The branch and PR were therefore created with the active GitHub CLI accountEthan-Dunia, which is the company account.