Open
Conversation
src/Response/Exception.php
Outdated
| namespace Cassandra\Response; | ||
|
|
||
| class Exception extends \Cassandra\Exception {} No newline at end of file | ||
| class Exception implements \Cassandra\Exception {} No newline at end of file |
There was a problem hiding this comment.
Why implements? \Cassandra\Exception is class but not interface.
Class Cassandra\Response\Exception cannot extend from interface Cassandra\Exception
Author
|
Fix for the following error FatalErrorException in Exception.php line 4: |
Author
|
@pincher2012 - Sorry i have reverted that implements to extends as it is the class and i have done one more fix now for the following error, File - src\Response\Error.php |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting PHP Warning: Declaration of Cassandra\Request\Batch::queryParameters($consistency, array $options = Array) should be compatible with Cassandra\Request\Request::queryParameters($consistency, array $values = Array, array $options = Array) in /var/www/html/php-cassandra/src/Request/Batch.php on line 122 for PHP7