Conversation
This commit fixes any clippy issues related to the MSRV 1.85, as well as the move to the stable toolchain. Due to support for usize from string in constant context, the konst dependency is no longer needed.
There was a problem hiding this comment.
Pull request overview
This PR updates the project to use Rust stable instead of a nightly version from 2023, requiring migration away from unstable APIs to their stabilized equivalents.
Changes:
- Migrated from Rust nightly (2023-05-22) to stable with edition 2021 and minimum Rust version 1.85
- Replaced unstable APIs with their stabilized versions (e.g.,
io::Error::other,is_some_and,inspect) - Removed the
konstdependency in favor of const-compatible standard library alternatives
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Updated Rust toolchain from nightly-2023-05-22 to stable |
| Cargo.toml | Updated edition to 2021, added rust-version 1.85, removed konst dependency |
| src/lib.rs | Replaced konst::primitive::parse_usize with usize::from_str_radix |
| src/transport/sockets.rs | Replaced io::Error::new with io::Error::other |
| src/transport/encoding/raptorq/decoder.rs | Replaced io::Error::new with io::Error::other and map with inspect |
| src/kbucket/key.rs | Replaced io::Error::new with io::Error::other and map_or with is_some_and |
| src/kbucket/bucket.rs | Added lifetime parameter to InsertOk, replaced map_or and map with is_some_and and inspect |
| src/kbucket.rs | Added lifetime parameter to InsertOk, removed unused BinaryNonce export, replaced map_or with is_some_and, removed redundant return |
| src/encoding/message.rs | Replaced io::Error::new with io::Error::other, removed unused ErrorKind import |
| src/encoding/header.rs | Replaced io::Error::new with io::Error::other, removed unused ErrorKind import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
herr-seppia
reviewed
Jan 26, 2026
herr-seppia
approved these changes
Feb 6, 2026
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request:
stableinstead of a specific nightly versionkonstdependency with standard library equivalent function